-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests around asset checkout #14755
Added tests around asset checkout #14755
Conversation
PR Summary
|
Description
This PR adds tests around asset checkout via the web and API. It also includes a small test to ensure the
LogListener
handling aonCheckoutableCheckedOut
event results in an entry in theaction_logs
table.The only real change to application code, besides removing some extra whitespace, is in the
AssetCheckoutRequest
where the rulesnullable
anddate
were added forcheckout_at
andexpected_checkin
.The test scenarios (methods in this case) between the two test cases are the same but the
testLicenseSeatsAreAssignedToUserUponCheckout
andtestCannotCheckoutAcrossCompaniesWhenFullCompanySupportEnabled
for the API is marked as incomplete since that behavior exists in the web but not in the API.I'm opening this against develop but I'm totally fine with this being moved to draft until after v7.
Type of change